Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: allow msDiff disable #208

Closed
wants to merge 1 commit into from
Closed

node: allow msDiff disable #208

wants to merge 1 commit into from

Conversation

dotmilk
Copy link

@dotmilk dotmilk commented Jun 28, 2015

@stephenmathieson stephenmathieson mentioned this pull request Sep 11, 2015
Closed
@iamsebastian
Copy link

If looks fine, would anybody be able to merge this? @TooTallNate maybe?

@dkebler
Copy link

dkebler commented Dec 16, 2015

Indeed, if this branch is ok to merge please do so and release. Thx.

@world
Copy link

world commented May 30, 2016 •
edited

This feature is dope. I mean WTF would the default be to measure ms with every single debug invocation with no ability to turn it off. Default noise is noise. Thank you @cheshirecatalyst!

@dotmilk
Copy link
Author

dotmilk commented Aug 1, 2016

@TooTallNate Any thoughts on this?

@monolithed
Copy link

It's really painful
img-2016-09-12-19-46-39

I like the idea to turn off time logging, but I suggest using something like DEBUG=-time

@thebigredgeek
Copy link
Contributor

thebigredgeek commented Nov 14, 2016 •
edited

@TooTallNate thoughts here? Might be yet another environment variable :/

@thebigredgeek thebigredgeek added the discussion This issue is requesting comments and discussion label Nov 14, 2016
@thebigredgeek
Copy link
Contributor

@dotmilk can you update code so that we can consider a merge?

@thebigredgeek thebigredgeek added the change-minor This proposes or provides a change that requires a minor release label Nov 14, 2016
@thebigredgeek thebigredgeek modified the milestones: 2.4.0, 2.5.0 Nov 14, 2016
@thebigredgeek thebigredgeek added the feature This proposes or provides a feature or enhancement label Nov 14, 2016
@dotmilk
Copy link
Author

dotmilk commented Nov 15, 2016

@thebigredgeek I don't even have this repo laying around anymore.

@thebigredgeek
Copy link
Contributor

Thanks for letting us know :)

@LadyK-21 LadyK-21 mentioned this pull request Jun 3, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change-minor This proposes or provides a change that requires a minor release discussion This issue is requesting comments and discussion feature This proposes or provides a feature or enhancement
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dotmilk @iamsebastian @dkebler @world @monolithed @thebigredgeek