Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): ignore bower.json in npm installations. #437

Merged
merged 1 commit into from Apr 4, 2017

Conversation

@joaovieira
Copy link
Contributor

@joaovieira joaovieira commented Mar 28, 2017

This may confuse and break some loaders (e.g. webpack) that are configured to read bower.json descriptor files (see codewizz/bower-resolve-webpack-plugin#2 (review)). Installed NPM modules do not require bower.json as it also points to a non-existent file (dist/debug.js). Edited: that was in v2.2.0.

This is common for isomorphic libraries (e.g. visionmedia/superagent@8ae7380) (just noticed superagent is from you guys as well :D)

@coveralls
Copy link

@coveralls coveralls commented Mar 28, 2017

Coverage Status

Coverage remained the same at 63.75% when pulling 212ddc9 on joaovieira:patch-1 into 27d93a3 on visionmedia:master.

@thebigredgeek thebigredgeek merged commit 9742c5f into visionmedia:master Apr 4, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 63.75%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.