Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline extend function in node implementation #452

Merged
merged 1 commit into from May 10, 2017

Conversation

@dougwilson
Copy link
Contributor

@dougwilson dougwilson commented May 2, 2017

This is a proposed solution for the Node.js 0.6 breakage I reported in #450 . This replaces the use of util._extend with an inlined version of the minimal implementation.

@coveralls
Copy link

@coveralls coveralls commented May 2, 2017

Coverage Status

Coverage increased (+0.05%) to 63.804% when pulling a697a07 on dougwilson:node-06-extend into c211947 on visionmedia:master.

@TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented May 2, 2017

Nice find @dougwilson! 👍

I can't help but wonder what you're doing with Node v0.6 still, though 😄

@dougwilson
Copy link
Contributor Author

@dougwilson dougwilson commented May 4, 2017

🤷‍♂️

@thebigredgeek thebigredgeek merged commit 1351d2f into visionmedia:master May 10, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 63.804%
Details
@dougwilson dougwilson deleted the dougwilson:node-06-extend branch May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.