Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Before after feature #50

Open
wants to merge 21 commits into
from

Conversation

Projects
None yet
6 participants

mgutz commented Dec 9, 2010

Implemented before and after life cycles for serial mode. As per our discussion, we should probably refactor the internals to sandbox each test method. I am still learning javascript outside of jQuery so will be glad to assist.

I added a gotcha section in the readme. Note, I do not have the utilities to regen the documentation HTML.

mgutz commented Dec 10, 2010

Renaming beforeAll to before might confuse users coming from other languages. In rspec and other frameworks before is an alias for beforeEach. I agree, the terminology isn't immediately clear. I wanted to rename beforeAll to beforeSuite but my brain thinks of a test suite in expresso as a test fixture. A test suite is comprised of test fixtures (too much enterprisey coding). I opted for something more generic, beforeThis. Feel free to change it.

Is there any plans to accept the pull request soon?

The beforeAll/afterAll would really make life easier. At the moment my tests hang cause I can't get the right place to end my db connection, and trying to use setup and teardown ended up in (even when running in serial mode) randomly getting EPIPE errors.

I was using a pre-commit hook to autotest using expresso before I the commit was committed, but now cause it's hanging I can't do that cause it doesn't get to exit.

This feature really will round off the test suite.

jshaw86 commented Jul 17, 2011

+1 having similar problems as fluffy

emostar commented Jul 26, 2011

+1 for a merge of this

sha1dy commented Aug 1, 2011

+1 please do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment