New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for percentage values #69
Conversation
nice! can we keep the conditionals on one line? otherwise looks good to merge! |
I fixed to one line |
@andrepolischuk good catch! But IMHO checking for percent/px by the type of value looks confusing for users. I think, the better way is to add Please, can you update behaviour to make it more flexible? |
And one little note — can you move this logic into helper function in the bottom of the file? It's pretty nice place for DRY 'cause of many duplications :D |
Sure |
@shuvalov-anton, I fixed |
Thanks) |
👍 |
Add percentage values for translate, fix #40