Skip to content
This repository

Running "n stable" removed bin, lib, share and include directories from /usr/local #86

Closed
davidcornu opened this Issue October 04, 2012 · 40 comments
David Cornu

I believe this has something to do with the following lines (https://github.com/visionmedia/n/blob/master/bin/n#L138-156). Am still investigating as to why exactly this happened.

Running the latest version from master on Mac OS X 10.8.2.

Notes

  • Adding echo $N_PREFIX on line 143 returns /usr/local, which seems normal as line 6 is N_PREFIX=${N_PREFIX-/usr/local}.
  • Tested on a fresh ubuntu 12.04 install, got the same result
Paper Creatures Ltd

This also just happened to me.

Thomas Parslow

Might be an idea to fix this and release an update guys or if you can't do that then remove n from package managers and let users know. It's pretty serious and it's been 3 days without an answer already, how many more victims are you waiting for?

Where's that space this time...

But seriously though, try running it with -x.

mr.The

Looks like this epic thread: MrMEEE/bumblebee-Old-and-abbandoned@a047be8

David Cornu

After rebuilding my homebrew install (at work I might add), I've moved to nvm.
@mrThe that was entertaining.

Tom Longson
nym commented October 07, 2012

FWIW, this is on Hacker News' front page: #86

benatkin
Collaborator

I used blame to find out where those lines got added, and I found that it was the next most recent issue: #85

That's one of an open source programmer's worst nightmares: a pull request that does something bad but looks benign. The simplest thing would be for @visionmedia to just revert it.

Vinod Chandru

@Hello71 Was looking for the space too...

Stephen Sugden

FWIW it's Canadian Thanksgiving this weekend so it's certainly possible TJ hasn't seen this yet.

Tom Longson
nym commented October 07, 2012

Really, you're blaming Canada... ?

Matt Iversen

I never knew the github issue tracker was actually a bunch of image forum threads....

You know it's a big issue when the majority of comments are pointless GIFs.

TJ Holowaychuk
Owner

hahahaha good call on thanks giving i just got home. I haven't been reviewing PRs properly for n(1) lately since I don't have much time, if they don't work as advertised, sorry haha, I'd love to have someone else maintain n(1) if anyone is up to it. limbo-merges seem to be digging a grave

benatkin
Collaborator
TJ Holowaychuk
Owner

added you! to be honest I don't even use any of these tools anymore, I just install from source, which is maybe once every ~5 months anyway

David Cornu

@visionmedia That's all fine and dandy but if the project is not being actively maintained, something in the readme would be greatly appreciated (see this commit as an example).

TJ Holowaychuk
Owner

well ideally it "just works" and continues to "just work" but it's been slowly more and more messed up as I've merged half-baked patches and node changing conventions etc

benatkin
Collaborator
TJ Holowaychuk
Owner

yeah it's kinda tough when you have 250+ OSS projects, inevitably some get messed up over time and I merge broken shit haha, funny thing is then I get comments like the one guy in here visionmedia/jade#629 trying to make me merge something I haven't properly reviewed and that has low test coverage, at the end of the day every feature or bit of code is something I have to maintain

benatkin
Collaborator

Cross-posting this comment by @visionmedia from HN:

my bad, sorry about the limbo-merge guys, I'll read PRs closer and/or ignore them since I don't have time

https://news.ycombinator.com/item?id=4625237

Yes that's a good idea to ignore things when you don't have time. Besides the potential for bugs, it makes it look like it's actively maintained when it isn't. If there had been nothing for three months, @davidcornu probably would have noticed, even without the README change.

Anorov

That commit definitely looks like it was intentional and malicious.

#85

@Suor seems to be responsible.

edit: Nevermind I'm wrong.

Alexander Schepanovski

@Anorov not malicious, I just screwed up.

I use n with N_PREFIX=~/local, removing lib, include and other dirs is actually desirable in that setting.
I didn't realize that dirs are used for something other than node in different env.

Anorov

@Suor, sorry, it just looked odd by replacing a bunch of cp commands with a single "rm -rf". I see your point now though.

Behrang Saeedzadeh

lulz!

Harry Jeffery

Deja vu, bumblebee. Deja vu.

Olli K

@visionmedia Don't worry, you still rock :D

TJ Holowaychuk
Owner

this pull-request kinda illustrates how terrible the unix directory structure is, anti-modularity ftw

Sergio Tapia Gutierrez

This thread is a disgrace. Stop posting so many image macros that contribute zilch to the developers of this project.

Casey Sanders

I came for the images, stayed for the comments complaining about the images.

TJ Holowaychuk
Owner

hahaha yeah that looks about right

Eudis Duran

These images are epic, it's like Reddit, only on github!

svartalf

Go away, /usr/local/!

TJ Holowaychuk visionmedia closed this January 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.