On OSX revert back to terminal hack to avoid a readline bug #15

merged 1 commit into from Sep 19, 2012

2 participants


Ran into an issue with one of my apps, I believe it's a readline/process issue, but this reverts the ctrl+u clearing back to \r only for OSX.

This still works on Windows and everywhere else, but this fixes an issue when you have several child processes sharing the same stdin, the ctrl+u actually looks to be getting called once per child that's bound and not just once. So the progress bar will write one line and delete 10 (one per child) before it..

Totally screwy and will take a ton of debugging, but this works for now.

Sloth member
tj commented Sep 19, 2012

haha, node is so portable!!, sucks that windows terminals dont handle \r correctly

@tj tj merged commit f0e3963 into visionmedia:master Sep 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment