tick(0) should not be the same as tick() #5

merged 1 commit into from Mar 10, 2012


None yet
2 participants

angel333 commented Mar 10, 2012

I noticed that progress bars are shown on the first tick. The problem is that e.g. for a db migration script which i'm now creating, the db commands are sent, than there is a huge (like 10 seconds) pause, and after that pause, the progress is finally shown. I wanted the progress bar to be shown immediately, even if it shows 0%. However, when I tried tick(0), it was considered as tick(), which I think is wrong.

It's very easy to fix, please see the commit attached.

Thank you for a great library, btw!

@tj tj added a commit that referenced this pull request Mar 10, 2012

@tj tj Merge pull request #5 from angel333/master
tick(0) should not be the same as tick()

@tj tj merged commit a10eaee into visionmedia:master Mar 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment