Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashbang option added. #86

Closed
wants to merge 1 commit into from
Closed

Hashbang option added. #86

wants to merge 1 commit into from

Conversation

@quangv
Copy link

@quangv quangv commented Jan 25, 2014

For older browsers or incapable web-servers, converts all urls to hashbangs.

Usage:

page('/list/:id', function(){
  // do stuff
})
page({hashbang:true});

<a href="/list/1">List 1</a>
// would go to /#!/list/1 and get handled properly.
@nwmcsween
Copy link
Contributor

@nwmcsween nwmcsween commented Feb 18, 2014

Should this be optional? In my opinion we should provide the needed hooks and use the history polyfill for incapable browsers #48

@cdekok
Copy link

@cdekok cdekok commented Mar 6, 2014

Please add this feature for IE 9 support 👍

@quangv
Copy link
Author

@quangv quangv commented Apr 3, 2014

Should this be optional? In my opinion we should provide the needed hooks and use the history polyfill for incapable browsers #48

@nwmcsween for my case, it was for a server that didn't support dynamic routing. ymmv

@elidupuis
Copy link

@elidupuis elidupuis commented Apr 14, 2014

+1. I think adding this option would allow page.js to be used for PhoneGap/Cordova apps.

@conraddecker
Copy link
Contributor

@conraddecker conraddecker commented Sep 19, 2014

I've updated @quangv 's work here to account for recent work that had been done on the library. Hopefully it'll clear up the merge conflicts and can get merged into master: #128

@quangv
Copy link
Author

@quangv quangv commented Sep 19, 2014

@conraddecker nice, I will close this PR. Thanks!

@quangv quangv closed this Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants