Warn when using unsupported mix of send and field #1153

Merged
merged 1 commit into from Jan 11, 2017

Projects

None yet

2 participants

@pornel
Collaborator
pornel commented Jan 10, 2017

Warn about gotcha in #1152

@pornel pornel Warn when using unsupported mix of send and field
df495b2
@focusaurus focusaurus merged commit 23ca7c1 into master Jan 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@focusaurus focusaurus deleted the sendwarn branch Jan 11, 2017
@focusaurus
Collaborator

I have no real opinion on this but would console.warn be slightly more semantically correct if we consider these "warnings"? I think ultimately this is going to cause misbehavior so they usually do represent actual errors in the application needing a code change to fix. (In which case console.error seems like the best choice)

@pornel
Collaborator
pornel commented Jan 11, 2017

I have no strong opinion either way. I went withconsole.error, because it may become an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment