Makefile enhancements #2

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@strk

strk commented Jul 3, 2012

Exposes a "make check" (per GNU standards) and becomes tolerant to presence or absence of a local mocha.

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj Jul 3, 2012

Member

IMO mocha should always be localized like any other dep

Member

tj commented Jul 3, 2012

IMO mocha should always be localized like any other dep

@strk

This comment has been minimized.

Show comment Hide comment
@strk

strk Jul 4, 2012

@visionmedia if it is localized it will be used as such by make, if it isn't it will attempt to work anyway.
b239fb4 just expands PATH to prepend node_modules/.bin, in the same way done by "npm test"

strk commented Jul 4, 2012

@visionmedia if it is localized it will be used as such by make, if it isn't it will attempt to work anyway.
b239fb4 just expands PATH to prepend node_modules/.bin, in the same way done by "npm test"

@donpark donpark referenced this pull request Nov 19, 2012

Closed

Feature: chaining #14

@gjohnson

This comment has been minimized.

Show comment Hide comment
@gjohnson

gjohnson Sep 16, 2013

Member

Closing. You will get mocha localized after npm install, which you need to run anyways to pick up the other dependencies that are required for development.

Member

gjohnson commented Sep 16, 2013

Closing. You will get mocha localized after npm install, which you need to run anyways to pick up the other dependencies that are required for development.

@gjohnson gjohnson closed this Sep 16, 2013

@strk

This comment has been minimized.

Show comment Hide comment
@strk

strk Sep 16, 2013

What about the check alias for test ?

strk commented Sep 16, 2013

What about the check alias for test ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment