How can I create alarm dialog with no cancel button? #41

Open
lexer opened this Issue Apr 13, 2012 · 8 comments

Comments

Projects
None yet
2 participants
@lexer

lexer commented Apr 13, 2012

Should I make my own implementation like Confirmation dialog, or it is possible to reuse confirmation dialog for this purpose?

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj Apr 13, 2012

Owner

hmmm yeah maybe, or use the notifications maybe?

Owner

tj commented Apr 13, 2012

hmmm yeah maybe, or use the notifications maybe?

@lexer

This comment has been minimized.

Show comment Hide comment
@lexer

lexer Apr 13, 2012

In our app we need to show modal window that will block user until he read the message and press "Ok"

lexer commented Apr 13, 2012

In our app we need to show modal window that will block user until he read the message and press "Ok"

@lexer

This comment has been minimized.

Show comment Hide comment
@lexer

lexer Apr 13, 2012

Another example. User should be blocked until he will receive response via push notification. If user don't want to wait he ca press single button "Cancel" and resume his work.

lexer commented Apr 13, 2012

Another example. User should be blocked until he will receive response via push notification. If user don't want to wait he ca press single button "Cancel" and resume his work.

@lexer

This comment has been minimized.

Show comment Hide comment
@lexer

lexer Apr 13, 2012

May be it would be better to modify confirmation to show ok and cancel only if they are declared. This is how android Alerts are designed for example.

new ConfirmationDialog().ok("done") - this is alarm dialog with single ok button
new ConfirmationDialog().cancel("reset") - this is alarm dialog with single cancel button.

However in this design it should be named smth like "AlarmDialog" that is more generic name.

Have you also thought about separate callbacks? .ok("done", function(){ });

lexer commented Apr 13, 2012

May be it would be better to modify confirmation to show ok and cancel only if they are declared. This is how android Alerts are designed for example.

new ConfirmationDialog().ok("done") - this is alarm dialog with single ok button
new ConfirmationDialog().cancel("reset") - this is alarm dialog with single cancel button.

However in this design it should be named smth like "AlarmDialog" that is more generic name.

Have you also thought about separate callbacks? .ok("done", function(){ });

@lexer

This comment has been minimized.

Show comment Hide comment
@lexer

lexer Apr 13, 2012

I mean "AlertDialog" not alarm. We will try to make a pull request today.

lexer commented Apr 13, 2012

I mean "AlertDialog" not alarm. We will try to make a pull request today.

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj Apr 13, 2012

Owner

yeah we could have an Alert and ui.alert(msg) with .modal() etc default. modals in generate are kinda bad UX but I can see in some cases if you have a critical issue that needs attention

Owner

tj commented Apr 13, 2012

yeah we could have an Alert and ui.alert(msg) with .modal() etc default. modals in generate are kinda bad UX but I can see in some cases if you have a critical issue that needs attention

@lexer

This comment has been minimized.

Show comment Hide comment
@lexer

lexer Apr 13, 2012

yep sure. modal should be optional.

lexer commented Apr 13, 2012

yep sure. modal should be optional.

@lexer

This comment has been minimized.

Show comment Hide comment
@lexer

lexer Apr 13, 2012

We have added pull request #42

lexer commented Apr 13, 2012

We have added pull request #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment