Skip to content
This repository

Fix IE8 error when a Dialog with effect closes #47

Merged
merged 1 commit into from almost 2 years ago

2 participants

jpjoyal TJ Holowaychuk
jpjoyal

use trusty closure instead of IE's broken setTimeout argument passing

jpjoyal Fix IE8 error when a dialog with effect closes
use closure instead of IE's broken setTimeout argument passing
3e01c18
TJ Holowaychuk visionmedia merged commit c1737db into from
TJ Holowaychuk visionmedia closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jun 04, 2012
jpjoyal Fix IE8 error when a dialog with effect closes
use closure instead of IE's broken setTimeout argument passing
3e01c18
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 2 additions and 2 deletions. Show diff stats Hide diff stats

  1. 4  lib/components/dialog/dialog.js
4  lib/components/dialog/dialog.js
@@ -225,9 +225,9 @@ Dialog.prototype.hide = function(ms){
225 225
   // hide / remove
226 226
   this.el.addClass('hide');
227 227
   if (this._effect) {
228  
-    setTimeout(function(self){
  228
+    setTimeout(function(){
229 229
       self.remove();
230  
-    }, 500, this);
  230
+    }, 500);
231 231
   } else {
232 232
     self.remove();
233 233
   }
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.