handle confirmation closed through overlay click + unbind keydown #54

Merged
merged 1 commit into from Jul 11, 2012

Conversation

Projects
None yet
2 participants
Contributor

pgherveou commented Jul 11, 2012

  • emit close when user click on overlay
  • unbind document keydown on remove
- emit close when user click on overlay
- unbind document keydown on remove

@pgherveou pgherveou referenced this pull request Jul 11, 2012

Closed

unbind keydown #52

@@ -248,5 +249,6 @@ Dialog.prototype.hide = function(ms){
Dialog.prototype.remove = function(){
this.emit('hide');
this.el.remove();
+ $(document).unbind('keydown.dialog');
@tj

tj Jul 11, 2012

Owner

i dont remember off hand where this binding is, in overlay? if so maybe it should be moved there

@tj

tj Jul 11, 2012

Owner

nvm it's not

tj added a commit that referenced this pull request Jul 11, 2012

Merge pull request #54 from pgherveou/patch-3
handle confirmation closed through overlay click + unbind keydown

@tj tj merged commit d75189a into visionmedia:master Jul 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment