setTimeout() in Dialog#show() may cause miscalculation of dialog position #62

wants to merge 3 commits into


None yet

1 participant


see commit message.

fschaefer added some commits Nov 11, 2013
@fschaefer fschaefer dialog: remove setTimeout() in Dialog#render()
The displaying of the dialog is deferred by removing the hide class in
a setTimeout() call. A subsequent call to Dialog#show() might calculate
a wrong dialog width due to the deferred hide class removal.
@fschaefer fschaefer dialog: remove duplicate show event in Dialog#show() f28777e
@fschaefer fschaefer menu: improve slug generation in Menu#add()
This allows the use of html as text argument in Menu#add().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment