Skip to content

Commit

Permalink
Revert r5970 and r5975.
Browse files Browse the repository at this point in the history
  • Loading branch information
fschneider@chromium.org committed Dec 13, 2010
1 parent 9977abb commit b1a2cc1
Show file tree
Hide file tree
Showing 11 changed files with 65 additions and 223 deletions.
10 changes: 3 additions & 7 deletions src/arm/ic-arm.cc
Expand Up @@ -2360,8 +2360,10 @@ Condition CompareIC::ComputeCondition(Token::Value op) {
void CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) {
HandleScope scope;
Handle<Code> rewritten;
#ifdef DEBUG
State previous_state = GetState();
State state = TargetState(previous_state, x, y);
#endif
State state = TargetState(x, y);
if (state == GENERIC) {
CompareStub stub(GetCondition(), strict(), NO_COMPARE_FLAGS, r1, r0);
rewritten = stub.GetCode();
Expand All @@ -2381,12 +2383,6 @@ void CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) {
#endif
}


void PatchInlinedSmiCode(Address address) {
UNIMPLEMENTED();
}


} } // namespace v8::internal

#endif // V8_TARGET_ARCH_ARM
7 changes: 0 additions & 7 deletions src/full-codegen.h
Expand Up @@ -38,9 +38,6 @@
namespace v8 {
namespace internal {

// Forward declarations.
class JumpPatchSite;

// AST node visitor which can tell whether a given statement will be breakable
// when the code is compiled by the full compiler in the debugger. This means
// that there will be an IC (load/store/call) in the code generated for the
Expand Down Expand Up @@ -536,10 +533,6 @@ class FullCodeGenerator: public AstVisitor {
// Helper for calling an IC stub.
void EmitCallIC(Handle<Code> ic, RelocInfo::Mode mode);

// Calling an IC stub with a patch site. Passing NULL for patch_site
// indicates no inlined smi code and emits a nop after the IC call.
void EmitCallIC(Handle<Code> ic, JumpPatchSite* patch_site);

// Set fields in the stack frame. Offsets are the frame pointer relative
// offsets defined in, e.g., StandardFrameConstants.
void StoreToFrameField(int frame_offset, Register value);
Expand Down
8 changes: 0 additions & 8 deletions src/ia32/assembler-ia32.h
Expand Up @@ -571,14 +571,6 @@ class Assembler : public Malloced {
static const byte kTestEaxByte = 0xA9;
// One byte opcode for test al, 0xXX.
static const byte kTestAlByte = 0xA8;
// One byte opcode for nop.
static const byte kNopByte = 0x90;

// One byte opcode for a short unconditional jump.
static const byte kJmpShortOpcode = 0xEB;
// One byte prefix for a short conditional jump.
static const byte kJccShortPrefix = 0x70;


// ---------------------------------------------------------------------------
// Code generation
Expand Down
4 changes: 2 additions & 2 deletions src/ia32/code-stubs-ia32.cc
Expand Up @@ -1366,8 +1366,8 @@ void TypeRecordingBinaryOpStub::GenerateSmiCode(MacroAssembler* masm,
if (op_ == Token::DIV || op_ == Token::MOD) {
left = eax;
right = ebx;
__ mov(ebx, eax);
__ mov(eax, edx);
__ mov(ebx, eax);
__ mov(eax, edx);
}


Expand Down
6 changes: 3 additions & 3 deletions src/ia32/code-stubs-ia32.h
Expand Up @@ -231,16 +231,16 @@ class TypeRecordingBinaryOpStub: public CodeStub {
ASSERT(OpBits::is_valid(Token::NUM_TOKENS));
}

TypeRecordingBinaryOpStub(
int key,
TypeRecordingBinaryOpStub(int key,
TRBinaryOpIC::TypeInfo operands_type,
TRBinaryOpIC::TypeInfo result_type = TRBinaryOpIC::UNINITIALIZED)
: op_(OpBits::decode(key)),
mode_(ModeBits::decode(key)),
use_sse3_(SSE3Bits::decode(key)),
operands_type_(operands_type),
result_type_(result_type),
name_(NULL) { }
name_(NULL) {
}

// Generate code to call the stub with the supplied arguments. This will add
// code at the call site to prepare arguments either in registers or on the
Expand Down

0 comments on commit b1a2cc1

Please sign in to comment.