Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to ci process including docker tpl builds #4992

Merged
merged 17 commits into from Aug 25, 2020

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Aug 21, 2020

updates scripts to build and tag a tpl container for ci
adds azure testing
adds docs about the ci container build process

@cyrush cyrush marked this pull request as draft August 21, 2020 20:54
@cyrush cyrush marked this pull request as ready for review August 25, 2020 14:00
@cyrush
Copy link
Member Author

cyrush commented Aug 25, 2020

Ready for review: CI docker container update, and move to use Azure.

Also includes docs about the new process -- which includes new script to automate building containers with unique tags that we can then ref in our CI scripts, vet and update via a PR.

@cyrush cyrush requested a review from brugger1 August 25, 2020 14:02
@cyrush
Copy link
Member Author

cyrush commented Aug 25, 2020

Note: I stopped circle CI testing in this PR, that is why circle is failing.

brugger1
brugger1 previously approved these changes Aug 25, 2020
Copy link
Collaborator

@brugger1 brugger1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/doc/dev_manual/CI.rst Outdated Show resolved Hide resolved
src/doc/dev_manual/CI.rst Outdated Show resolved Hide resolved
Copy link
Member

@markcmiller86 markcmiller86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyrush this is awesome 🎁

azure-pipelines.yml Outdated Show resolved Hide resolved
scripts/ci/docker/Dockerfile Show resolved Hide resolved
scripts/ci/docker/build_docker_visit_ci.py Show resolved Hide resolved
src/doc/dev_manual/CI.rst Outdated Show resolved Hide resolved
src/doc/dev_manual/CI.rst Outdated Show resolved Hide resolved
scripts/ci/docker/build_docker_visit_ci.py Show resolved Hide resolved
@cyrush
Copy link
Member Author

cyrush commented Aug 25, 2020

@markcmiller86 added more details about docker hub, etc, thanks for the feedback!

markcmiller86
markcmiller86 previously approved these changes Aug 25, 2020
@cyrush cyrush merged commit 70a49d2 into develop Aug 25, 2020
@cyrush cyrush deleted the task/2020_08_ci_docker_update branch August 25, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants