Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vis#4123: rotating axis labels #9

Merged
merged 9 commits into from Sep 13, 2019
Merged

vis#4123: rotating axis labels #9

merged 9 commits into from Sep 13, 2019

Conversation

mojoaxel
Copy link
Member

@mojoaxel mojoaxel commented Aug 6, 2019

This PR was originally introduces by @eanar with almende/vis#4123

I cherry-picked all commits from almende/vis#4123 and also the relevant example from eanar.github.io.


This feature is to help improve the readability of long axis label names. The option can be useful for visualizations where a longer label name with more data is preferred. It can help with readability when the graph rotates into a 2D heatmap. An example with JSON data set is provided.

image

eanar and others added 8 commits August 6, 2019 20:25
These are optional functions separate from existing drawAxisLabel<XYZ> functions.
The setAxisLabelMethod() is called from setOptions and sets each _drawAxisLabel<XYZ> function for use from within _redrawAxis and using their .call(this, ...) methods.
These options allow for quicker style adjustments.
A readme is commented inside rotateAxisLabels.html
The example provides a sample JSON data set and the use of long axis lables
Change _onTooltip delay back to 300
Remove tooltipDelay from Graph3d.DEFAULTS
Remove tooltipDelay from option.js
Remove tooltipDelay from Settings.js
@mojoaxel mojoaxel mentioned this pull request Aug 6, 2019
3 tasks
@mojoaxel mojoaxel requested a review from a team August 6, 2019 18:52
Copy link
Member

@Thomaash Thomaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Thomaash Thomaash merged commit 3098c4c into master Sep 13, 2019
@vis-bot
Copy link
Collaborator

vis-bot commented Sep 13, 2019

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants