Update tests to use pytest better #1775
Conversation
|
Thanks for looking in to this. It looks like |
|
What do you think about removing the |
depends on how much you want to review Why is numpydoc simply not a test dependency? |
appveyor.yml
Outdated
| PIP_DEPENDENCIES: "numpydoc https://files.pythonhosted.org/packages/71/5f/07aad120ca6e4339a5c127631341787bc6bc74add39a1f41223bda949721/freetype_py-2.1.0.post1-py2.py3-none-win_amd64.whl" | ||
| - PYTHON_VERSION: "3.7" | ||
| CONDA_DEPENDENCIES: "numpy scipy setuptools nose pytest coverage pytest-cov pytest-sugar pytest-faulthandler cython coveralls" | ||
| CONDA_DEPENDENCIES: "numpy scipy setuptools pytest coverage pytest-cov pytest-sugar pytest-faulthandler cython coveralls" | ||
| PIP_DEPENDENCIES: "numpydoc https://files.pythonhosted.org/packages/71/5f/07aad120ca6e4339a5c127631341787bc6bc74add39a1f41223bda949721/freetype_py-2.1.0.post1-py2.py3-none-win_amd64.whl" |
There was a problem hiding this comment.
Why do you need this numpydoc dependency?
There was a problem hiding this comment.
i see, you needed bleeding edge at one point. Seems like both freetype-py and numpydoc got released on conda-forge as you required.
|
now that you have embraced the wild wild west of conda-forge, you should be able to fully test everything on conda soon: conda-forge/staged-recipes#10342 |
You mean, no pip installs? At first I thought you meant run vispy tests on the conda-forge builds.
Just missed dependencies.
I assumed it would be a small change along with the other import changes you did. Since pytest is required I thought it made sense and was going to do it myself, but since you're already changing this I thought I'd ask. Thanks again. |
|
The other thing about numpydoc is that for rendering the sphinx docs we could probably just use napolean that now comes with sphinx. |
|
Apparently flake8-docstring is much more strict that numpydoc. If you install flake8-docstrings and run the normal flake checks: |
# Conflicts: # .travis.yml # appveyor.yml # azure-pipelines.yml # vispy/testing/_runners.py # vispy/testing/_testing.py # vispy/util/fonts/tests/test_font.py
|
A lot of this was handled similarly in another PR by @larsoner, but there were some things in here I didn't want to lose. The stuff discussed here as alternative solutions (flake8-docstrings, napolean, etc), we can handle in another PR. Thanks! |
Needs: #1774
Which has been folded into this.