WIP: Volume rendering & camera changes by almarklein · Pull Request #612 · vispy/vispy

almarklein · 2014-11-08T07:23:46Z

This PR implements volume rendering. It's basically a port of the technique that I use in Visvis.

New Volume visual with two rendering styles (iso and mip).
Volume example in examples/scene/volume.py Try it, and use the keys to switch cameras etc.
Refactored cameras a bit in general
Refactored TurnTableCamera: no more mode and distance. You can just change the fov while getting the same zoom level. Setting fov to 0 means orthographic. Zooming is done by moving camera backward.
New FlyCamera to fly around your data.

This is about ready. There are more things to do, but that can be picked up in another PR. (I added todo items for this in volume.py)

I wish to do more with the camera's, but we should probably discuss this first. Will make a new issue for this.

todo:

avoid warning when swithching render styles
camera's

closes issue #725

Closes #725

larsoner · 2014-11-08T08:20:03Z

What is the relationship to the existing WIP volume rendering PR? Does it
supersede it, or is it complementary?

almarklein · 2014-11-08T09:47:47Z

It's another technique. And I believe that @lcampagn had yet another technique in mind. So I guess they can be complimentary. We probably have to make a list of advantages / disadvantages of the different techniques to see whether we need all of them.

almarklein · 2014-11-08T09:52:36Z

@lcampagn this is the code to get the transform from camera to scene, required to calculate the view direction vector in the vertex shader.

It's not valid because it depends on scenegraph; this kind of behavior is only allowed for VisualNode subclasses.
You could try using the method described in my visual tutorial 5, but perhaps we should wait until that PR is settled..

Sure, this needs to be implemented in a better way. One idea is to let the transformsystem object have a "cameratransform" (or something with a better name). On the event object this transform will be implemented in the way that I did it here.

almarklein · 2014-11-11T23:01:18Z

Changed the data to the MRI data that is in our demo-data directory. Will also upload the stent volume soon. So you guys can check the render if you want. Note that this is still WIP though ...

One thing that I want to address is improving our camera models and implement a camera that you can fly around ala flight-sim. The current render technique is set up to allow cameras inside the volume, which would be really awesome if we could make it work correctly...

almarklein · 2014-11-26T16:12:32Z

This is finally ready for review. I invite you to try out the new volume example.

Be sure to press "1" to select the fly-camera, and then WASD + mouse to fly through the volume.
Press "i" and "m" to toggle between isosurface and mip render styles.
With the turntable camera, use CTRL+RMB to smoothly change the fov from orthographic to perspective.

almarklein · 2014-11-26T16:12:44Z

cc @izaid

almarklein · 2014-11-26T16:15:11Z

@lcampagn I though the visuals were mixed, but the base Node was not a visual?

This was just easier. We can separate Node / NodeVisual later if necessary.

campagnola · 2014-11-26T16:21:25Z

Looks great!

Artifact--looks like the texture is wrapping around?

campagnola · 2014-11-26T16:24:31Z

almarklein · 2014-11-26T16:35:22Z

@lcampagn the Turntable camera has changed, and does no longer have distance and mode properties.

campagnola · 2014-11-26T16:47:57Z

This (was) automatically called by ViewBox.. why should this be done with parenting instead?

Because it would be nice if a user can just grab a camera and place it in a new scene: cam.parent = another_viewbox.scene and it would be able adjust itself.

But why is that better than viewbox.set_camera(...) or whatever we have already?

Ah, I think what you were trying to do is allow cameras with no parents to be used. But this would allow a camera to be a child of one scene, while it uses in another (to which it is not a child), which is weird. We should probably discuss this further in #647 when we discuss allowing multiple cameras-multiple scenes.

almarklein · 2014-11-27T12:08:07Z

Updated: addressed some comments. Also fixed the artifact: that was related to a bug in gloo causing the texture wrapping in z-direction not to be set. I think the most "controversial" changes are related to the cameras. I propose we discuss what to do with that in #647. I can implement a new kind of turntable camera that is closer to the original version, if you want.

* aspect_ratio -> scale_ratio * aspect_fixed -> fixed_ratio * set_range() can be called before association with a viewbox * set_range queries scene bounds more efficiently * Line visual handles bounds better * And some small details ...

almarklein · 2015-03-10T11:14:15Z

@campagnola Thanks for the review. Addressed comments. Travis is green (except that I managed to misspell "size skip").

coveralls · 2015-03-10T20:08:49Z

Coverage decreased (-1.83%) to 77.02% when pulling fde101f on almarklein:volume into 0444b69 on vispy:master.

coveralls · 2015-03-10T20:11:43Z

Coverage decreased (-1.83%) to 77.02% when pulling 196129c on almarklein:volume into 0444b69 on vispy:master.

coveralls · 2015-03-10T20:11:45Z

Coverage decreased (-1.83%) to 77.02% when pulling 196129c on almarklein:volume into 0444b69 on vispy:master.

coveralls · 2015-03-25T17:42:44Z

Coverage decreased (-1.65%) to 77.14% when pulling 45b8335 on almarklein:volume into cce5011 on vispy:master.

coveralls · 2015-03-25T17:42:46Z

Coverage decreased (-1.65%) to 77.14% when pulling 45b8335 on almarklein:volume into cce5011 on vispy:master.

WIP: Volume rendering & camera changes

almarklein mentioned this pull request Nov 8, 2014

Visual tutorial #611

Merged

almarklein reviewed Nov 8, 2014
View reviewed changes

almarklein force-pushed the volume branch 2 times, most recently from fb1ec2a to c49d48c Compare November 26, 2014 14:26

almarklein reviewed Nov 26, 2014
View reviewed changes

campagnola reviewed Nov 26, 2014
View reviewed changes

Comment thread examples/basics/plotting/mesh.py Outdated

campagnola Nov 26, 2014

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

almarklein mentioned this pull request Nov 26, 2014

Improvements to cameras #647

Closed

7 tasks

campagnola reviewed Nov 26, 2014
View reviewed changes

almarklein added 7 commits March 10, 2015 10:37

fix style and minor issues [size skip]

5c3b3b9

Address reviewer comments:

d357d12

* aspect_ratio -> scale_ratio * aspect_fixed -> fixed_ratio * set_range() can be called before association with a viewbox * set_range queries scene bounds more efficiently * Line visual handles bounds better * And some small details ...

TurntableCamera can set distance

38a4035

style [size skip]

5cfdafc

PanZoom.zoom is relative [size skip]

1174418

Skip style test [size skip]

aa1bbca

address reviewer comments

fde101f

almarklein force-pushed the volume branch from 77f6231 to fde101f Compare March 10, 2015 09:37

fix tube example [ssize skip]

196129c

larsoner added the sprint-2015 label Mar 18, 2015

almarklein changed the title ~~WIP: Volume rendering~~ WIP: Volume rendering & camera changes Mar 24, 2015

almarklein added 6 commits March 24, 2015 15:49

camera cleanup part 1

ffc4952

PanZoomCamera back to its original "approach" with new features

ec0e8b7

Camera cleanup

c987572

Last touches on cameras

bf46723

zoom factor OK!

8324a7d

Merge and final touches [skip size]

45b8335

almarklein added a commit that referenced this pull request Mar 25, 2015

Merge pull request #612 from almarklein/volume

3b19080

WIP: Volume rendering & camera changes

almarklein merged commit 3b19080 into vispy:master Mar 25, 2015

almarklein deleted the volume branch March 25, 2015 17:47

rossant mentioned this pull request Mar 25, 2015

Mouse interaction in mesh example is wrong #747

Closed

royerloic mentioned this pull request Jun 5, 2018

3D viewer napari/napari-core#7

Open

djhoese added type: enhancement and removed type: feature labels Nov 25, 2019

Conversation

almarklein commented Nov 8, 2014

Uh oh!

larsoner commented Nov 8, 2014

Uh oh!

almarklein commented Nov 8, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

almarklein commented Nov 11, 2014

Uh oh!

almarklein commented Nov 26, 2014

Uh oh!

almarklein commented Nov 26, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

campagnola commented Nov 26, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

almarklein commented Nov 26, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

almarklein commented Nov 27, 2014

Uh oh!

almarklein commented Mar 10, 2015

Uh oh!

coveralls commented Mar 10, 2015

Uh oh!

coveralls commented Mar 10, 2015

Uh oh!

coveralls commented Mar 10, 2015

Uh oh!

coveralls commented Mar 25, 2015

Uh oh!

coveralls commented Mar 25, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants