New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '_Alignof' to Lexer.x (fixes #7) #8

Merged
merged 1 commit into from Jun 27, 2016

Conversation

Projects
None yet
2 participants
@jjst
Copy link

jjst commented Jun 22, 2016

Tested by doing a cabal build with no issues.

I tried running the test harness but it looks like it's broken -- complains about "CTest: osx-1.c: copyFile: does not exist (No such file or directory)" -- is this a known issue?

@visq

This comment has been minimized.

Copy link
Owner

visq commented Jun 26, 2016

Hi Jeremie,
thanks a lot for your efforts, I'm in the process this fix with other changes for C11 compatibility. Could you give me details concerning the problem you witnessed with the test harness?

@visq visq merged commit 74f8939 into visq:master Jun 27, 2016

@jjst

This comment has been minimized.

Copy link

jjst commented Jun 27, 2016

Hey,

so I was following the instructions from the testing section of the README, just wanted to make sure my changes didn't introduce any regressions before sending the PR. I first ran make in the test/ subfolder, which went fine, but then when running make again in test/harness/, I get this:

[...]
make[1]: Leaving directory '/home/jjst/dev/language-c/test/harness/analysis_type_check'
make -C attributes clean all
make[1]: Entering directory '/home/jjst/dev/language-c/test/harness/attributes'
rm -rf *.log
sh ../../bin/compile_log.sh deprecated
sh ../../bin/compile_log.sh deprecated-2
sh ../../bin/compile_log.sh deprecated-3
sh ../../bin/compile_log.sh deprecated-bitfield-init
../../bin/CTest osx-1.c
CTest: osx-1.c: copyFile: does not exist (No such file or directory)
Makefile:8: recipe for target 'osx' failed
make[1]: *** [osx] Error 1
make[1]: Leaving directory '/home/jjst/dev/language-c/test/harness/attributes'
Makefile:19: recipe for target 'attributes.runtest' failed
make: *** [attributes.runtest] Error 2

Looks like this osx-1.c file is missing here. It is referenced in test/harness/attributes/Makefile. Looking at the git history, the first reference to this file dates back from 6f42409 which added the osx target to the Makefile. Maybe this file was to be added to this commit or something?

@visq

This comment has been minimized.

Copy link
Owner

visq commented Jun 28, 2016

Hi Jeremie,
thanks for the reply, the file is indeed missing in the github repo, but was present in the official darcs repo. Fixed in a6d62d6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment