Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce type consistency between the methods, and their C API #20

Closed
yeesian opened this issue Mar 25, 2016 · 2 comments
Closed

Enforce type consistency between the methods, and their C API #20

yeesian opened this issue Mar 25, 2016 · 2 comments

Comments

@yeesian
Copy link
Member

yeesian commented Mar 25, 2016

In some cases, the function in src/ogr_api.jl operates on Ptr{OGRLayerH}, whereas the corresponding C API expects OGRLayerH.

One specific example: https://github.com/visr/GDAL.jl/blob/master/src/ogr_api.jl#L3997-L4010 and https://github.com/visr/GDAL.jl/blob/master/src/C/ogr_api.jl#L4000-L4013
@yeesian yeesian mentioned this issue Mar 27, 2016
Closed
@visr
Copy link
Member

visr commented Nov 10, 2017

Does this still apply, or should it be closed?

@yeesian
Copy link
Member Author

yeesian commented Nov 11, 2017

I'd recommend to close it for now; I can open a new issue if i come across it.

@yeesian yeesian closed this as completed Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yeesian @visr