model loader fix #8

Merged
merged 1 commit into from Mar 10, 2013

Conversation

Projects
None yet
3 participants
@natlownes
Member

natlownes commented Mar 10, 2013

when setting collection.url in the loader, wrap call to each collection's url function in a closure

fixes issue where the url for the last collection defined in the collectionTypes
object would be requested for each collection

model loader - when setting collection.url wrap call to each collecti…
…ons url

function in a closure

fixes issue where the url for the last collection defined in the collectionTypes
object would be requested Object.keys(collectionTypes).length times
@jawsthegame

This comment has been minimized.

Show comment Hide comment
@jawsthegame

jawsthegame Mar 10, 2013

Member

Nice.

  • Tom

On Mar 10, 2013, at 12:19 PM, Nat Lownes notifications@github.com wrote:

when setting collection.url in the loader, wrap call to each collection's url function in a closure

fixes issue where the url for the last collection defined in the collectionTypes
object would be requested for each collection

You can merge this Pull Request by running

git pull https://github.com/natlownes/quips model_loader_urlFunc_fix_up
Or view, comment on, or merge it at:

#8

Commit Summary

model loader - when setting collection.url wrap call to each collections url
File Changes

M models/loader.coffee (2)
M test/models/loader_spec.coffee (31)
Patch Links:

https://github.com/vistarmedia/quips/pull/8.patch
https://github.com/vistarmedia/quips/pull/8.diff

Member

jawsthegame commented Mar 10, 2013

Nice.

  • Tom

On Mar 10, 2013, at 12:19 PM, Nat Lownes notifications@github.com wrote:

when setting collection.url in the loader, wrap call to each collection's url function in a closure

fixes issue where the url for the last collection defined in the collectionTypes
object would be requested for each collection

You can merge this Pull Request by running

git pull https://github.com/natlownes/quips model_loader_urlFunc_fix_up
Or view, comment on, or merge it at:

#8

Commit Summary

model loader - when setting collection.url wrap call to each collections url
File Changes

M models/loader.coffee (2)
M test/models/loader_spec.coffee (31)
Patch Links:

https://github.com/vistarmedia/quips/pull/8.patch
https://github.com/vistarmedia/quips/pull/8.diff

markchadwick added a commit that referenced this pull request Mar 10, 2013

@markchadwick markchadwick merged commit c957633 into vistarmedia:master Mar 10, 2013

1 check passed

default The Travis build passed
Details

@natlownes natlownes deleted the natlownes:model_loader_urlFunc_fix_up branch Jan 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment