Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Breaking] Upgrade to jQuery(ify) 1.9.1 #9

Merged
merged 1 commit into from Mar 15, 2013

Conversation

Projects
None yet
3 participants
Owner

markchadwick commented Mar 11, 2013

The jqueryify2 project was forked from
jqueryify due to a slight incompatibility
in headless tests. Because of this, Quips was locked to an older version of
jQuery.

In the passing time, the jqueryify library has integrated a fix and migrated to
a more recent jQuery library (1.9.1). This library has a number of small
incompatibilities with Quips' expectations, outlined below.

  • Empty response bodies with a 200 status are treated as failures. The correct
    status should be 204. Rather than checking for this behavior and correct the
    HTTP response status in Quips, I'm opting to require consumers fix this, as an
    empty response is distinctly different than one with a body.
  • The jQuery.Deferred.is* methods appear to have been replaced with a .state()
    method which returns a string.
  • select elements on the DOM now treat .val() like a text field, however, the
    DOM does not update the option element with a "selected" property.
@markchadwick markchadwick [Breaking] Migrate from jqueryify2 to jqueryify
The [jqueryify2](https://npmjs.org/package/jqueryify2) project was forked from
[jqueryify](https://npmjs.org/package/jqueryify) due to a slight incompatibility
in headless tests. Because of this, Quips was locked to an older version of
jQuery.

In the passing time, the jqueryify library has integrated a fix and migrated to
a more recent jQuery library (1.9.1). This library has a number of small
incompatibilities with Quips' expectations, outlined below.

* Empty response bodies with a 200 status are treated as failures. The correct
  status should be 204. Rather than checking for this behavior and correct the
  HTTP response status in Quips, I'm opting to require consumers fix this, as an
  empty response is distinctly different than one with a body.
* The jQuery.Deferred.is* methods appear to have been replaced with a .state()
  method which returns a string.
* select elements on the DOM now treat .val() like a text field, however, the
  DOM does not update the option element with a "selected" property.
292090a
Owner

chrismcbride commented Mar 11, 2013

+1

Owner

natlownes commented Mar 11, 2013

oh word, fucking awesome.

@markchadwick markchadwick added a commit that referenced this pull request Mar 15, 2013

@markchadwick markchadwick Merge pull request #9 from markchadwick/master
[Breaking] Upgrade to jQuery(ify) 1.9.1
f5d4f88

@markchadwick markchadwick merged commit f5d4f88 into vistarmedia:master Mar 15, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment