Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last window size isn't remembered, top of GBA screen cut off #406

Closed
anLizard opened this issue Apr 7, 2019 · 6 comments
Closed

Last window size isn't remembered, top of GBA screen cut off #406

anLizard opened this issue Apr 7, 2019 · 6 comments
Assignees
Labels

Comments

@anLizard
Copy link

@anLizard anLizard commented Apr 7, 2019

Expected behavior

Emulator remembers window size from last time it was launched.
image

Actual behavior

Emulator always starts with same window size, regardless of previous size and the top of the GBA screen is cut off.
image
Resizing window solves it until emulator is closed again.

Steps to reproduce the behavior

Launch any ROM without changing window size

If you are using a BIOS file, please say which one.

Option details

Video driver (simple, opengl):
opengl

Sound driver (directsound, xaudio, openal, SDL):
sdl

Build details

Operating System (Windows, Mac, Linux (state distribution), etc.):
Window 10 Pro 64-bit 1803

Config file

https://privatebin.net/?0754d5cfe01a7ff5#3/eqNRrFDtCt1oTHaXZIJ4sLrNSYQPXMzoGXy7UUmbA=

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Apr 7, 2019

@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Apr 7, 2019

@denisfa looks like we have more work to do on this one

@denisfa

This comment has been minimized.

Copy link
Collaborator

@denisfa denisfa commented Apr 7, 2019

Yeah, can confirm both. One of them is an issue with the position (0,0) being a weird point for the app. The other one was new to me, though. I will be working on a solution.

denisfa added a commit that referenced this issue Apr 8, 2019
This issue was a combination of `wxSHAPED` and its effect on the custom
geometry. It is necessary to force a dummy resize so the display adjusts
itself.

- Fix #406
rkitover added a commit that referenced this issue Apr 9, 2019
Fix display when loading ROMs with custom geometry.

This issue was a combination of `wxSHAPED` and its effect on the custom
geometry. It is necessary to force a dummy resize so the display adjusts
itself.

Align game frame on center, both horizontal and vertical.
@rkitover rkitover self-assigned this Apr 17, 2019
@rkitover rkitover added the UI-Win label Apr 17, 2019
@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Apr 17, 2019

@anLizard hey, could you please test the latest release and see if you still have any geometry/position issues

@anLizard

This comment has been minimized.

Copy link
Author

@anLizard anLizard commented Apr 18, 2019

@anLizard hey, could you please test the latest release and see if you still have any geometry/position issues

Seems fixed on new release, although I get black bars.
image

@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Apr 18, 2019

Yeah the black bars are because of the "keep aspect ratio" option, you can stretch the window to minimize their appearance.

@rkitover rkitover added the fixed label Apr 18, 2019
@rkitover rkitover closed this Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.