Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VBA-M doesn't load #451

Closed
AyanamiRei1 opened this issue Jun 25, 2019 · 23 comments
Assignees
Labels

Comments

@AyanamiRei1
Copy link

@AyanamiRei1 AyanamiRei1 commented Jun 25, 2019

First I'm using Windows 10 Pro 64-bit 1809

Alright for the issue I'm trying to load it and all I'm getting is this error no idea why.

image

Cheers for the help.

@ZachBacon

This comment has been minimized.

Copy link
Contributor

@ZachBacon ZachBacon commented Jun 25, 2019

Please keep the standard issue template, it has questions there that are relevant such as are you using a release or nightly.

@AyanamiRei1

This comment has been minimized.

Copy link
Author

@AyanamiRei1 AyanamiRei1 commented Jun 25, 2019

Expected behavior
For it to work.

Actual behavior
Crashes while trying to open it.

Steps to reproduce the behaviour

Just trying to open the program causes this error.
image

Build details
Latest Stable.

@ZachBacon

This comment has been minimized.

Copy link
Contributor

@ZachBacon ZachBacon commented Jun 25, 2019

Give this a try https://github.com/visualboyadvance-m/visualboyadvance-m/files/3219928/visualboyadvance-m-Win-32bit.zip
At some point I'll see about doing a new nightly based on current changes. But this should be newer than the stable release.

@AyanamiRei1

This comment has been minimized.

Copy link
Author

@AyanamiRei1 AyanamiRei1 commented Jun 25, 2019

Still the same problem.

image

@ZachBacon

This comment has been minimized.

Copy link
Contributor

@ZachBacon ZachBacon commented Jun 25, 2019

So on all my windows based systems it does run, so there's something on your system that is causing a memory allocation exception within vba-m, or I should say that's my best guess on the matter. @rkitover what do you think?

@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Jun 25, 2019

I think I fixed this, try this nightly:

#354 (comment)

@AyanamiRei1

This comment has been minimized.

Copy link
Author

@AyanamiRei1 AyanamiRei1 commented Jun 25, 2019

Same issue boss.

image

And this is with the Nightly.

@ZachBacon

This comment has been minimized.

Copy link
Contributor

@ZachBacon ZachBacon commented Jun 25, 2019

Just out of curiosity, go to %USERPROFILE%\AppData\Local\visualboyadvance-m and remove (or backup) the ini, if there is one there and see if that will do anything.

@denisfa

This comment has been minimized.

Copy link
Collaborator

@denisfa denisfa commented Jun 25, 2019

@AyanamiRei1 Are you using a controller? We had an issue not so long ago that it was related to using a wii u pro controller with wiinUsoft app. It was the same error message and behaviour you describe here.

@NoDuff

This comment has been minimized.

Copy link

@NoDuff NoDuff commented Jul 6, 2019

I have the exact same issue with 2.1.2 and 2.1.3, but versions 2.1.1 and older work fine.

Deleting the config folder does not help.

After reading denisfa's post I remembered that I had a MayFlash Dolphin Sensor Bar connected to my computer. When I unplugged the sensor bar, the errors went away and now VBA-M loads.

Is this error potentially fixable? Or will I have to leave the affected device unplugged to run VBA-M?

@denisfa

This comment has been minimized.

Copy link
Collaborator

@denisfa denisfa commented Jul 6, 2019

@NoDuff It really depends on the issue itself... We don't have the controller/hardware available for testing, so we would need to keep asking users to test whatever possible solution we have... I believe that the easiest path is to ignore devices, but I would not be able to test it.

I have the exact same issue with 2.1.2 and 2.1.3, but versions 2.1.1 and older work fine.

I need to ask: does 2.1.1 loads and knows about the device or just ignore it?

@NoDuff

This comment has been minimized.

Copy link

@NoDuff NoDuff commented Jul 6, 2019

I would go with it ignores it. The sensor bar is pretty much custom made for the Dolphin emulator and I have never used it for anything else. I even forget it is still plugged in sitting on my monitor most of the time.

I loaded up 2.1.1 and while it didn't crash. I wasn't able to bind any controller keys or use the Wii Remote to play games. (while my XB360 controller worked just fine)

Update: I did some Googling and installed Touchmote (windows HID software for the sensor bar, which lets it work with more than just Dolphin) and it now does work in VBA-M 2.1.1, but newer versions still crash.

@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Jul 6, 2019

@denisfa see line 68 in sdljoy.cpp, this should be fixed, I have no idea how it still happens.

@terralilly85

This comment has been minimized.

Copy link

@terralilly85 terralilly85 commented Jul 9, 2019

Not sure if this should be a different thread, but I'm seeing the same error message. I have a WiiU Pro Controller running on WiinUSoft (latest version). If I disable Bluetooth completely, VBA-M will launch with no issues. If I have the controller connected and cloned to as an XInput device, VBA-M fails to launch. Is there some way I can get you any logs of the crash?

EDIT: I did try the other build in this thread, with the same results.

@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Jul 11, 2019

Thank you for confirming the bug still exists.

If someone with dev experience can give us a backtrace, it would be highly appreciated.

rkitover added a commit that referenced this issue Jul 11, 2019
SDL APIs like `SDL_JoystickNumAxes(dev)` can return a negative error
code. Handle this case better.

This should fix the fatal exception from trying to allocate an array
with an illegal size (negative, due to the error.)

Signed-off-by: Rafael Kitover <rkitover@gmail.com>
@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Jul 11, 2019

@terralilly85 @AyanamiRei1 @NoDuff

I realized what I was doing wrong, can you please try this build:

#354 (comment)

@terralilly85

This comment has been minimized.

Copy link

@terralilly85 terralilly85 commented Jul 11, 2019

Posted this in your link accidently:

@rkitover Same error on launch, however this time load was instant. On previous builds application load would take several minutes.

image

@NoDuff

This comment has been minimized.

Copy link

@NoDuff NoDuff commented Jul 11, 2019

Also continues to give the same error for me, and still takes about 20 seconds for the error to pop up (same as the release builds)

@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Jul 11, 2019

I actually posted the wrong build.

@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Jul 12, 2019

@terralilly85 @AyanamiRei1 @NoDuff

Sorry about that, I thought my script was making the .zip but it turns out I was uploading an old .zip.

Anyway, these are the right binaries:

#354 (comment)

@NoDuff

This comment has been minimized.

Copy link

@NoDuff NoDuff commented Jul 12, 2019

The 64bit build ran fine, no error at all. Looks like you squashed the bug.
VBA-M does still take around 20s to show initially show the window, which is a bit odd.

For some reason BitDefender flags the 32bit version as a virus: Atc4.Detection
A quick Google seems so show this as a common false positive.

@rkitover rkitover added fixed and removed partially fixed labels Jul 12, 2019
@terralilly85

This comment has been minimized.

Copy link

@terralilly85 terralilly85 commented Jul 12, 2019

I can also confirm that the x64 build squashed the bug. Load time seemed normal to me.

@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Jul 12, 2019

Thank you very much for testing! We should be doing a new release soon which will have this change.

@rkitover rkitover closed this Jul 12, 2019
@rkitover rkitover mentioned this issue Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.