Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filters xbrz 4x and above are slow with the simple video driver #55

Closed
ZachBacon opened this issue Dec 20, 2016 · 2 comments
Assignees

Comments

@ZachBacon
Copy link
Contributor

@ZachBacon ZachBacon commented Dec 20, 2016

Please fill out this form:

Expected behavior

xbrz filters 4x and above work as described.

Actual behavior

xbrz filters 4x and above only seem to work with opengl, but for the simple video driver stutters.

Steps to reproduce the behavior

Use the simple driver and select the filter.

Build details

Operating System (Windows, Mac, Linux, etc.): All Platforms

Interface (wx and SDL, default is wx): wxWidgets

Version of code (pre-built binary version, or commit ref, or just "master"): current master

Any other relevant build information:

If this is e.g. a joystick or video issue, then the relevant hardware information:
Video issue

@ZachBacon ZachBacon added the bug label Dec 20, 2016
@ZachBacon ZachBacon self-assigned this Dec 20, 2016
@rkitover rkitover changed the title Issue to track for myself. filters xbrz 4x and above are slow with the simple video driver Feb 4, 2017
@Squall-Leonhart

This comment has been minimized.

Copy link

@Squall-Leonhart Squall-Leonhart commented Apr 7, 2017

these filters were intended for the multithreaded D3D renderer, they are cpu intensive and will perform badly on the simple renderer

we need to get on top of mudlords suggestion and implement a multithreaded tile renderer.

@rkitover rkitover added this to To Do in release v2.1.7 Apr 20, 2019
@rkitover

This comment has been minimized.

Copy link
Collaborator

@rkitover rkitover commented Apr 20, 2019

Looking at this again.

The only platform where the simple driver is slow is Mac, because of quartz. The filter may make it even slower because it upscales the image.

There is some kind of filter thread code in the wx code, I need to see if it actually still works, this would be in effect before the output driver such as simple or opengl.

@rkitover rkitover added cannot reproduce and removed bug labels Aug 15, 2019
@rkitover rkitover closed this Aug 15, 2019
release v2.1.7 automation moved this from To Do to Done Aug 15, 2019
@rkitover rkitover removed this from Done in release v2.1.7 Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.