Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour of `Tools` > `Memory Viewer`. #486

Merged
merged 2 commits into from Aug 19, 2019
Merged

Fix behaviour of `Tools` > `Memory Viewer`. #486

merged 2 commits into from Aug 19, 2019

Conversation

@denisfa
Copy link
Collaborator

denisfa commented Aug 10, 2019

@rkitover This is like one of those dumb segfaults that I mentioned earlier. As soon as you click this item, it appears a wxWidgets error message. It has been like this since my pr to remove most of the compilation warnings...

@retro-wertz You are interested on this, at least at the time of the issue reporting. Check if this is what you want and test it, please. I know I can see rows of memory maps, but I don't know if they are correct or not. The GUI behaviour I could test myself, but we need to be sure that I am not going to break something else with this solution.

Feel free to comment whatever you want. If there is some type of improvement desired, leave a note. I will be off from now until next wednesday (14.8.19) to focus on personal stuff. When I am back, I will see what I can do for this.

We fix the wxWidgets error message when trying to open the dialog
via menu.

The scrollbar behaviour has been enhanced to adjust itself between
200 and 300 rows from GUI (0x6c0 memory to 0xf9ff - GB example).

Clicking on top or bottom line of the memory values now moves 1 row
position backwards and forward, respectively.

Arrow keys also functional for navigation.

- Fix #275
@denisfa denisfa requested review from rkitover and Aug 10, 2019
@ghost

This comment has been minimized.

Copy link

ghost commented Aug 10, 2019

nope. this does not fix the problem. this does allow to scroll but memory locations are invalid. Actually only the 0 - 0x2B0 is correct and the rest are invalid now.
Screenshot_2019-08-10_18-10-43

it even loops back to 0x0 once you go past 0xFFFFFFFF (which invalid to begin with since usable memory is only up to 0xE00FFFF)
Screenshot_2019-08-10_18-15-50

jumping to memory locations using the pull-down menu only moves on line at a time instead of going directly to specified address.

@denisfa denisfa mentioned this pull request Aug 14, 2019
@denisfa

This comment has been minimized.

Copy link
Collaborator Author

denisfa commented Aug 19, 2019

@rkitover Would you mind merging this? This is not the definitive solution, but at least restores the old behaviour with the corrected values (not giving an error message when we try to open it via menu).

I will keep the original issue open. I cannot tackle this at the moment because I don't quite understand what I have to see in the memory rows.

@rkitover

This comment has been minimized.

Copy link
Collaborator

rkitover commented Aug 19, 2019

Of course.

@rkitover rkitover merged commit fc2eb38 into master Aug 19, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@denisfa denisfa deleted the fix-mviewer branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.