Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix behaviour of `Tools` > `Memory Viewer`. #486
@rkitover This is like one of those dumb segfaults that I mentioned earlier. As soon as you click this item, it appears a wxWidgets error message. It has been like this since my pr to remove most of the compilation warnings...
@retro-wertz You are interested on this, at least at the time of the issue reporting. Check if this is what you want and test it, please. I know I can see rows of memory maps, but I don't know if they are correct or not. The GUI behaviour I could test myself, but we need to be sure that I am not going to break something else with this solution.
Feel free to comment whatever you want. If there is some type of improvement desired, leave a note. I will be off from now until next wednesday (14.8.19) to focus on personal stuff. When I am back, I will see what I can do for this.
We fix the wxWidgets error message when trying to open the dialog via menu. The scrollbar behaviour has been enhanced to adjust itself between 200 and 300 rows from GUI (0x6c0 memory to 0xf9ff - GB example). Clicking on top or bottom line of the memory values now moves 1 row position backwards and forward, respectively. Arrow keys also functional for navigation. - Fix #275
jumping to memory locations using the pull-down menu only moves on line at a time instead of going directly to specified address.
@rkitover Would you mind merging this? This is not the definitive solution, but at least restores the old behaviour with the corrected values (not giving an error message when we try to open it via menu).
I will keep the original issue open. I cannot tackle this at the moment because I don't quite understand what I have to see in the memory rows.