Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #52

Merged
merged 6 commits into from Dec 11, 2016
Merged

Various fixes #52

merged 6 commits into from Dec 11, 2016

Conversation

@Mystro256
Copy link
Contributor

Mystro256 commented Dec 11, 2016

Fixes to Manpages:

  • Man6 (Games) should be used instead of Man1 (General)
  • wxvbam manpage should match the new binary name
  • ENABLE_GTK3 should install gvbam manpage
  • Typos in GUI manpages and license clarification (I made this 4 years ago)

Fix FSF address information:

  • Some of the headers have the wrong information (documentation/license fix)

Add Linux AppData and fixes:

  • I made it so the desktop files are installed for Linux. I used "NOT WIN32 AND NOT APPLE". Please let me know if you feel this isn't sufficient. I'm not sure if there's a LINUX cmake keyword.
  • Added appdata (used for packaging in Linux)

Cmake Fixes:

  • The binary install commands were a little messed up, so I fixed most of the issues.
  • SDL manpage should only be installed if SDL is enabled
  • Inconsistent use of tabs and spaces, I just converted all indents to spaces
@Mystro256

This comment has been minimized.

Copy link
Contributor Author

Mystro256 commented Dec 11, 2016

My last pull request was a little rushed, but here are a bunch of fixes I've been working on.

@ZachBacon

This comment has been minimized.

Copy link
Contributor

ZachBacon commented Dec 11, 2016

For one thing. We are actually gonna axe gvbam and also the win32 only code and just leaving us with libretro, sdl and wxwidgets. I'll merge it in for now but know that in the future it won't matter.

@ZachBacon ZachBacon merged commit 0e9fb98 into visualboyadvance-m:master Dec 11, 2016
@Mystro256

This comment has been minimized.

Copy link
Contributor Author

Mystro256 commented Dec 11, 2016

Fair enough, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.