Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Some fixes for MSVC. #70
Add -std=gnu+11 to CMAKE_CXX_COMPILE_OBJECT in the main CMakeLists.txt to force the option for all C++ sources. The right way to do this is to use a generator expression with ADD_COMPILE_OPTIONS, but this is only available in cmake 3.3 and we must maintain 2.8.12 compatibility to support Ubuntu 14. This fixes the mac build (clang.)
I added a couple of tiny fixes, other than that
I was going to look at fixing VS cmake generation at some point, so thank you very much for doing this!
I had some questions, since I have only used VS a couple of times before, how do you build a cmake project such as this in VS? Do you download the mingw tarballs for the deps and use the cmake GUI to set paths to them, or some other way? Can we automate this (perhaps by including everything in the dependencies submodule?)
I was going to play with this, essentially full free VS:
Move the check for dependencies/msvc into the previous IF(WIN32) block adding an IF(MSVC) level. Remove duplicate call to INCLUDE_DIRECTORIES(dependencies/msvc) from later on in the main CMakeLists.txt.
It's a long story about how to build vba-m with cmake & VS.
The most libraries needed was built before I met vba-m.
Since many other things(e.g. gettext) are not installed on my box, I disabled some corresponding options in cmake command line to work around.
The command line I used to generate the VS solution/projects with cmake:
Awesome, thank you for the info, if and when I have time, I will try to replicate the process and see if we can automate it a bit more as well.
As for YASM, there is no explicit YASM support in the cmake files yet, I will need to add that.
I told @doctorwho11 that everything is good to merge.
You can find us on