New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Short Codes and Alphameric sender ID #39

Merged
merged 6 commits into from Dec 6, 2017

Conversation

Projects
None yet
3 participants
@Marahin
Contributor

Marahin commented Nov 24, 2017

Tested on example app:

Sent text to +48 12 545 67 89
Texter: User#welcome
Date: 2017-11-24 15:39:54 +0100
From: Team Sp.z.o.o
To: +48 12 545 67 89
Rendered user_texter/welcome.text.erb (0.2ms)

Keep in mind that in order to use Alphanumeric sender ID you have to declare it this way: from: 'My Team <Team Inc.>', where 'My Team' will be equal to name, and Team Inc. to Sender ID (.from_phone).

Show outdated Hide outdated Gemfile Outdated
Show outdated Hide outdated lib/textris/message.rb Outdated
Show outdated Hide outdated lib/textris/message.rb Outdated
Show outdated Hide outdated lib/textris/message.rb Outdated

philnash and others added some commits Nov 7, 2016

Add .idea to .gitignore
.idea folder contains JetBrains' IDE data and configurations,
it should not be added to the project.
Add support for alphameric sender ID and short codes
Continue support introduction (based on @philnash's code:
#26)
for Short Codes and fulfill request to bring Alphameric
Sender ID support. Handle formatting/discovery logic in newly
created class, Textris::PhoneFormatter.
Show outdated Hide outdated lib/textris/message.rb Outdated
Do not use `&.` notation, and instead make explicit capture calls
`&.` breaks backward compatibility - instead add explicit calls
that check if there are any matches; and if there are - select the captures.
Show outdated Hide outdated lib/textris/phone_formatter.rb Outdated
Show outdated Hide outdated spec/textris/phone_formatter_spec.rb Outdated

@Marahin Marahin merged commit 66ed742 into master Dec 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Marahin Marahin deleted the short-codes-alphamerics branch Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment