Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vitaGL support #252

Merged
merged 2 commits into from May 19, 2018

Conversation

Projects
None yet
2 participants
@Rinnegatamante
Copy link
Collaborator

Rinnegatamante commented May 15, 2018

No description provided.

@Rinnegatamante Rinnegatamante force-pushed the Rinnegatamante:vitagl branch 3 times, most recently from 0ea7e17 to 0ade437 May 15, 2018

@Rinnegatamante Rinnegatamante force-pushed the Rinnegatamante:vitagl branch from 0ade437 to a8eef19 May 18, 2018

@@ -388,6 +398,11 @@ void uniform_matrix_4<GLfloat>(GLint location, GLsizei count, GLboolean transpos
glUniformMatrix4fv(location, count, transpose, value);
}

template <>
void uniform_matrix_4<GLint>(GLint location, GLsizei count, GLboolean transpose, const GLint *value) {
glUniform4iv(location, count, (GLint *)value);

This comment has been minimized.

Copy link
@VelocityRa

VelocityRa May 18, 2018

Member

shouldn't this be something in the likes of glUniformMatrix* like the above?

This comment has been minimized.

Copy link
@Rinnegatamante

Rinnegatamante May 19, 2018

Author Collaborator

Uniform matrix exists only for floats. This is here just to make the compiler not error out.

@Rinnegatamante Rinnegatamante merged commit 233b01d into Vita3K:master May 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.