New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature for Groups #382

Closed
antoniopaisfernandes opened this Issue Dec 3, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@antoniopaisfernandes
Contributor

antoniopaisfernandes commented Dec 3, 2015

A nice feature would add the ability to hide devices of certain groups (Groups devices visibility):
image

Do you believe it is worth developing (I could try it) & merging?

Best regards,
António

@antoniopaisfernandes

This comment has been minimized.

Show comment
Hide comment
@antoniopaisfernandes

antoniopaisfernandes Dec 3, 2015

Contributor

Being clearer, the idea is to have a mapVisibility boolean in the group (defaulting to true). If one set up the group to be mapVisibility = false, the devices would not be 'printed' on the map.
The screenshot would show only the 'red' vans :)

Contributor

antoniopaisfernandes commented Dec 3, 2015

Being clearer, the idea is to have a mapVisibility boolean in the group (defaulting to true). If one set up the group to be mapVisibility = false, the devices would not be 'printed' on the map.
The screenshot would show only the 'red' vans :)

@vitalidze

This comment has been minimized.

Show comment
Hide comment
@vitalidze

vitalidze Dec 3, 2015

Owner

This should be implemented as a part of #118/#205/#333. I thought about adding a special column with check boxes to the devices list at the left, which will be called 'Visibility' (an eye icon at the grid header). Marking device as invisible should hide it from map. All invisible devices must be tied to the user account (maybe saved in UI settings), so when user logs back in he won't see previously hidden devices.

Then there should be some controls which will allow to change the visibility of a batch of devices (like for the devices from group, offline/offline devices, idle devices). That selection should be also saved in the user profile, so when the status of some device changes it will be hidden automatically.

I don't have the full picture on how it should be implemented, but I believe this is the only solid way to handle all cases at once.

Owner

vitalidze commented Dec 3, 2015

This should be implemented as a part of #118/#205/#333. I thought about adding a special column with check boxes to the devices list at the left, which will be called 'Visibility' (an eye icon at the grid header). Marking device as invisible should hide it from map. All invisible devices must be tied to the user account (maybe saved in UI settings), so when user logs back in he won't see previously hidden devices.

Then there should be some controls which will allow to change the visibility of a batch of devices (like for the devices from group, offline/offline devices, idle devices). That selection should be also saved in the user profile, so when the status of some device changes it will be hidden automatically.

I don't have the full picture on how it should be implemented, but I believe this is the only solid way to handle all cases at once.

vitalidze added a commit that referenced this issue Dec 10, 2015

vitalidze added a commit that referenced this issue Dec 10, 2015

For #118 #205 #382 - implemented dynamic visibility calculation based…
… on the status of device, handle the 'forced' visibility and 'hidden' flags

vitalidze added a commit that referenced this issue Dec 10, 2015

vitalidze added a commit that referenced this issue Dec 10, 2015

@vitalidze

This comment has been minimized.

Show comment
Hide comment
@vitalidze

vitalidze Dec 10, 2015

Owner

Implemented, written news and article, updated latest and demo version.

Owner

vitalidze commented Dec 10, 2015

Implemented, written news and article, updated latest and demo version.

@vitalidze vitalidze closed this Dec 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment