New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power settings #276
Power settings #276
Conversation
I will not merge this because:
|
The logic is applied in the branch mdev - for generating detailed reports I do not understand on what you insist in third bullet. If this pullrequest is accepted next step would be merging the mdev in your On Wed, Sep 30, 2015 at 8:17 AM, Vitaly Litvak notifications@github.com
|
I don't like the idea for user to mess with XML/JSON values. What I meant is that there are already sensors settings, where you define their names and intervals. 'Power' and 'io240' are both sensors. So I believe you should define their possible values (like 0/1) and types (like 'ignition' or 'battery') in the same place, i.e. on the same tab. You can also copy these settings between devices if needed. Then if you want to use it for stops (or trips) detection you should define it at the same place where you define the 'idle speed limit' setting. I think this way it will be more user-friendly. |
OK. I though that, at this stage of iteration, is more important functionality than to be user-friendly. |
I don't like the idea to re-implement it later, so from my point of view this should be done using the right approach from the start. Maybe the UI should lack, or other functionality should lack, but we should look into future while making these decisions. I don't see any reason why it can't be done as a setting for sensor, it's not so hard to implement, just a little bit more work required. Anyway, in near future I am planning to start working myself on #210 and the reports will be close to the version described here. I will add sensor types and make other necessary changes during implementation. |
According to #273 it has been added field powerConditions in table Devices and in dialog DeviceDialog.