Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 changes #146

Closed
vitalik opened this issue Jun 4, 2021 · 7 comments
Closed

v1 changes #146

vitalik opened this issue Jun 4, 2021 · 7 comments

Comments

@vitalik
Copy link
Owner

vitalik commented Jun 4, 2021

Outlining here potential backward incompatible changes that might be introduced in v1 release

  • auth will be class interface instead of callable (to support async authenticators)
  • responses to support codes/headers/content (like general Response class)
  • routers paths joined with "/" - which might not needed on some cases where router prefix will act like a prefix and not subfolder
@vitalik vitalik pinned this issue Sep 19, 2021
@ahmadaidin
Copy link

ahmadaidin commented Nov 23, 2021

is there any plan to add custom decorator support to the api module?

@vitalik
Copy link
Owner Author

vitalik commented Nov 23, 2021

is there any plan to add custom decorator support to the api module?

what do you mean ? example ?

@ahmadaidin
Copy link

ahmadaidin commented Nov 23, 2021

is there any plan to add custom decorator support to the api module?

what do you mean ? example ?

I tried to implement an async decorator to check whether user exists or not on database before an API function is called. At first I got an error and I think it's impossible to add any async decorator for now. But then I found a way to create one and it works. So, I think it's already solved.

@mathiasag7
Copy link

When i add List[ModelSchema] in another schema, he generate an error "AttributeError: fields". I don't understand why

@WarKaa
Copy link

WarKaa commented Feb 23, 2022

Hey @vitalik thank you for your great work

Will it be possible in v1 to add custom example to our open api schemas like in https://fastapi.tiangolo.com/tutorial/schema-extra-example/?h=example#pydantic-schema_extra ?

@rngallen
Copy link

When i add List[ModelSchema] in another schema, he generate an error "AttributeError: fields". I don't understand why

Kindly share your schema and models code. It will be easy to solve having some hints

@A-Asror
Copy link

A-Asror commented Aug 19, 2022

will there be permission , for example, like django rest framework !?

and would like to be able to define serialization depth in schema class, example:

class UserSchemaIn(ModelSchema):

    class Config:
        model = UserModel
        depth = 1
        model_fields = ("password", "username", "email", "first_name", "last_name")

Repository owner deleted a comment from SaluteGF Oct 28, 2022
@vitalik vitalik unpinned this issue Feb 6, 2023
@vitalik vitalik closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants