Enhancement to enable styling of the vertical bar #133

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

grrowl commented Feb 23, 2012

(such as a custom height and/or margin) and have the verticalTrack respond properly

@grrowl grrowl Enhancement to enable styling of the vertical bar (such as a custom h…
…eight and/or margin) and have the verticalTrack respond properly
1592430
Owner

vitch commented Feb 23, 2012

Thanks! Do you have an example of what you would be trying to achieve by styling the vertical bar like this? I haven't tested the patch but I'd want to make sure that a styled bar didn't introduce any other problems (with e.g. calculation of the bounds for the bar to scroll within with different sized content or when the pane is reinitialised) before pulling...

grrowl commented Feb 27, 2012

I've put together a basic demo of the effect I achieved: http://www.chillidonut.com/junk/jscrollpane.1592430e/demo.html

Why you do not include this request into the main repository?

Owner

vitch commented Dec 11, 2013

Sorry, I missed the example that was provided and now it's not online any more :(

I'm still not sure what this PR helps with. What can you do with it that you can't do with caps and gutters? Does it break uses based on dynamic height content?

I'm still not sure what this PR helps with. What can you do with it that you can't do with caps and gutters? Does it break uses based on dynamic height content?

You are right. All that I need I can do using caps and gutters.

Owner

vitch commented Dec 13, 2013

Cool :)

Closing for now, I'll re-open if someone can explain the use-case for the PR...

vitch closed this Dec 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment