Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Enhancement to enable styling of the vertical bar #133

Closed
wants to merge 1 commit into from

3 participants

@grrowl

(such as a custom height and/or margin) and have the verticalTrack respond properly

@grrowl grrowl Enhancement to enable styling of the vertical bar (such as a custom h…
…eight and/or margin) and have the verticalTrack respond properly
1592430
@vitch
Owner

Thanks! Do you have an example of what you would be trying to achieve by styling the vertical bar like this? I haven't tested the patch but I'd want to make sure that a styled bar didn't introduce any other problems (with e.g. calculation of the bounds for the bar to scroll within with different sized content or when the pane is reinitialised) before pulling...

@grrowl

I've put together a basic demo of the effect I achieved: http://www.chillidonut.com/junk/jscrollpane.1592430e/demo.html

@4you4ever

Why you do not include this request into the main repository?

@vitch
Owner

Sorry, I missed the example that was provided and now it's not online any more :(

I'm still not sure what this PR helps with. What can you do with it that you can't do with caps and gutters? Does it break uses based on dynamic height content?

@4you4ever

I'm still not sure what this PR helps with. What can you do with it that you can't do with caps and gutters? Does it break uses based on dynamic height content?

You are right. All that I need I can do using caps and gutters.

@vitch
Owner

Cool :)

Closing for now, I'll re-open if someone can explain the use-case for the PR...

@vitch vitch closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 23, 2012
  1. @grrowl

    Enhancement to enable styling of the vertical bar (such as a custom h…

    grrowl authored
    …eight and/or margin) and have the verticalTrack respond properly
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  script/jquery.jscrollpane.js
View
2  script/jquery.jscrollpane.js
@@ -272,7 +272,7 @@
appendArrows(verticalTrack, settings.verticalArrowPositions, arrowUp, arrowDown);
}
- verticalTrackHeight = paneHeight;
+ verticalTrackHeight = verticalBar.height();
container.find('>.jspVerticalBar>.jspCap:visible,>.jspVerticalBar>.jspArrow').each(
function()
{
Something went wrong with that request. Please try again.