AWAC implementation #115
Merged
AWAC implementation #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitchyr
approved these changes
Aug 9, 2020
| from rlkit.torch.pytorch_util import activation_from_string | ||
|
|
||
|
|
||
| class CNN(PyTorchModule): |
There was a problem hiding this comment.
btw, are you still using this? it could be nice to only use BasicCNN
There was a problem hiding this comment.
It's in a few imports but I am not really using this in recent code. The only file that does seem to use that might be a bit annoying to address is ConvVAE (because a lot of other code uses it). So I think deleting this is best deferred to later?
|
Also, there's a bunch of files here that we could probably delete since we never use |
|
Here are the results of this branch on AWAC, SkewFit, and SAC: https://drive.google.com/file/d/1Qy5SYIGNwdeTHAGNjbRfuP5pSiRw8JzJ/view?usp=sharing I went through and did some more cleanup as well. I think this is ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is running now, but still testing AWAC and skewfit as a regression test.