perf: lazy load workbox-build to reduce config loading time#244
Merged
userquin merged 1 commit intovite-pwa:mainfrom Apr 18, 2022
Merged
perf: lazy load workbox-build to reduce config loading time#244userquin merged 1 commit intovite-pwa:mainfrom
userquin merged 1 commit intovite-pwa:mainfrom
Conversation
|
✔️ Deploy Preview for vite-plugin-pwa ready! 🔨 Explore the source changes: 68ac570 🔍 Inspect the deploy log: https://app.netlify.com/sites/vite-plugin-pwa/deploys/622b0abc665fa600097745fd 😎 Browse the preview: https://deploy-preview-244--vite-plugin-pwa.netlify.app |
Member
|
sorry for the delay, testing with vitesse template also the dev startup from 2s to 1.2s, loading vite v2.9.0 dev server running at:
> Local: http://localhost:3333/
> Network: use `--host` to expose
ready in 1201ms.with static import: vite v2.9.0 dev server running at:
> Local: http://localhost:3333/
> Network: use `--host` to expose
ready in 2069ms. |
userquin
approved these changes
Apr 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was thinking that vite's starting up time was slow in my project.
I digged down a bit and found that evaluating
workbox-buildwas making it slow.This PR changes
workbox-buildto be lazy loaded.Since
workbox-buildis not always used, I think it is ok to do this.Without this PR, my project takes about 1300 - 1500ms to start up.
With this PR, it takes about 500 - 600ms.
These values are obtained from output with
DEBUG="vite:config" npm run devlikebundled config file loaded in 565.03ms +0ms.