Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support for Vite 3.1 #371

merged 13 commits into from Sep 20, 2022

feat!: support for Vite 3.1 #371

merged 13 commits into from Sep 20, 2022


Copy link

@userquin userquin commented Sep 7, 2022

This PR includes:

  • migrate to Vite 3.1.0
  • updated all dependencies with taze major -r -w: pnpm to 7.12.0
  • updated docs to use the latest VitePress: using the buildEnd hook to build the pwa (once added the its integration will be updated)
  • included new sequential closeBundle hook on build plugin with default order: will help to configure latest SvelteKit
  • tested all examples with prompt strategy except sveltekit that should be removed from the examples folder: react/preact/solid/svelte/vue

@antfu @benmccann the SvelteKit integration repo will be moved to the new org later, I've sent invitations to work directly on that repo.

Before merging this, we should release one last 0.12.8 version including PR 376 and 373.

supersedes #370

closes #357

Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for vite-plugin-pwa ready!

Name Link
🔨 Latest commit cc53a60
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

# Conflicts:
#	package.json
#	src/api.ts
#	src/types.ts
@userquin userquin requested a review from antfu September 19, 2022 20:25
Copy link
Member Author

Updated pnpm to use 7.12.0

Copy link
Member Author

I need to review the pwa info plugin and the api, it seems we need to expose the info with some flags

@antfu antfu merged commit 4a9e8b9 into main Sep 20, 2022
@antfu antfu deleted the feat/vite-3-migration branch September 20, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Create Vite 3 branch
2 participants