Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): return pwa info when required #378

merged 3 commits into from Sep 22, 2022


Copy link

@userquin userquin commented Sep 21, 2022

The webmanifest is not generated in SSR and it should be generated always.

Also returning the info when required: otherwise we return always the info with the hint about the register sw (inlined or registerSW).

Copy link

netlify bot commented Sep 21, 2022

Deploy Preview for vite-plugin-pwa ready!

Name Link
🔨 Latest commit e1a6229
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin requested a review from antfu September 21, 2022 16:31
@userquin userquin marked this pull request as draft September 21, 2022 17:26
@userquin userquin marked this pull request as ready for review September 21, 2022 18:34
@userquin userquin changed the title fix(api): webmanifest should be generated always fix(api): return pwa info when required Sep 21, 2022
@userquin userquin merged commit 4927b19 into main Sep 22, 2022
@userquin userquin deleted the userquin/api-dont-check-ssr-for-webmanifest branch September 22, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants