Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: unregister docs from the plugin repo #408

merged 1 commit into from Dec 24, 2022


Copy link

@userquin userquin commented Nov 7, 2022

Since the rdirection to the new docs is already configured, we only need to add selfDestroying to the docs here, then on reload and once the pwa is deleted from the client, users will be redirected to the new docs.

This PR will be on draft until I merge and publish v0.13.4 with my 3 last pending PR and the integrations also released.

We need to add a new entry in the new docs repo about the pwa info virtual module, I'll send a PR later.

Once we have v0.13.4 and the integrations, we can merge this PR, we shouldn't remove the docs from here, but we need to freeze it (we also need to keep it on netlify or ppl won't be able to uninstall the old PWA, maybe in a future we can remove it also from netlify).

/cc @antfu (sorry for the ping)

Copy link

netlify bot commented Nov 7, 2022

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit 3023627
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin marked this pull request as ready for review December 24, 2022 14:59
@userquin userquin merged commit fd9475d into main Dec 24, 2022
5 checks passed
@userquin userquin deleted the userquin/docs-prepare-self-destroying-sw branch December 24, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant