From 6cd2d35d791311de953b7a832a877b1c98e2b2ed Mon Sep 17 00:00:00 2001 From: Evan You Date: Sun, 24 Jan 2021 21:19:29 -0500 Subject: [PATCH] fix: remove preload markers in all cases fix #1694 --- packages/vite/src/node/plugins/importAnaysisBuild.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/vite/src/node/plugins/importAnaysisBuild.ts b/packages/vite/src/node/plugins/importAnaysisBuild.ts index b7f7e1dc94f0aa..6b8b43f55a60bf 100644 --- a/packages/vite/src/node/plugins/importAnaysisBuild.ts +++ b/packages/vite/src/node/plugins/importAnaysisBuild.ts @@ -249,10 +249,11 @@ export function buildImportAnalysisPlugin(config: ResolvedConfig): Plugin { } chunk.code = s.toString() // TODO source map - } else { - // inlined dynamic import, remove the marker - chunk.code = code.replace(preloadMarkerRE, 'void 0') } + + // there may still be markers due to inlined dynamic imports, remove + // all the markers regardless + chunk.code = code.replace(preloadMarkerRE, 'void 0') } } }