From 6cda88d882ffcd5b3fdaa005296bfe1f0991925c Mon Sep 17 00:00:00 2001 From: Evan You Date: Tue, 12 Jan 2021 21:53:09 -0500 Subject: [PATCH] fix: properly externalize resolved external urls --- packages/vite/src/node/plugins/importAnalysis.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/vite/src/node/plugins/importAnalysis.ts b/packages/vite/src/node/plugins/importAnalysis.ts index bcb2b86de748c2..88e0202f255f65 100644 --- a/packages/vite/src/node/plugins/importAnalysis.ts +++ b/packages/vite/src/node/plugins/importAnalysis.ts @@ -182,14 +182,14 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin { url = resolved.id } + if (isExternalUrl(url)) { + return [url, url] + } + // if the resolved id is not a valid browser import specifier, // prefix it to make it valid. We will strip this before feeding it // back into the transform pipeline - if ( - !url.startsWith('.') && - !url.startsWith('/') && - !isExternalUrl(url) - ) { + if (!url.startsWith('.') && !url.startsWith('/')) { url = VALID_ID_PREFIX + resolved.id.replace('\0', NULL_BYTE_PLACEHOLDER) }