From 6f977a5f01604d406d2e0c74c4d01a79d3416f06 Mon Sep 17 00:00:00 2001 From: Dominik G Date: Thu, 30 Sep 2021 17:25:42 +0200 Subject: [PATCH] fix(cli): log correct hostname (#5156) --- packages/vite/src/node/cli.ts | 4 ++-- packages/vite/src/node/logger.ts | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/vite/src/node/cli.ts b/packages/vite/src/node/cli.ts index d9b509f5ee5c16..877f4d7edd8598 100644 --- a/packages/vite/src/node/cli.ts +++ b/packages/vite/src/node/cli.ts @@ -108,7 +108,7 @@ cli } ) - printHttpServerUrls(server.httpServer, server.config, options) + printHttpServerUrls(server.httpServer, server.config) // @ts-ignore if (global.__vite_start_time) { @@ -249,7 +249,7 @@ cli ) const server = await preview(config, cleanOptions(options)) - printHttpServerUrls(server, config, options) + printHttpServerUrls(server, config) } catch (e) { createLogger(options.logLevel).error( chalk.red(`error when starting preview server:\n${e.stack}`), diff --git a/packages/vite/src/node/logger.ts b/packages/vite/src/node/logger.ts index 5ba5adf7c63054..07bc63d1bfc758 100644 --- a/packages/vite/src/node/logger.ts +++ b/packages/vite/src/node/logger.ts @@ -6,7 +6,6 @@ import os from 'os' import readline from 'readline' import { RollupError } from 'rollup' import { ResolvedConfig } from '.' -import { ServerOptions } from './server' import { Hostname, resolveHostname } from './utils' export type LogType = 'error' | 'warn' | 'info' @@ -142,13 +141,12 @@ export function createLogger( export function printHttpServerUrls( server: Server, - config: ResolvedConfig, - options: ServerOptions + config: ResolvedConfig ): void { const address = server.address() const isAddressInfo = (x: any): x is AddressInfo => x.address if (isAddressInfo(address)) { - const hostname = resolveHostname(options.host) + const hostname = resolveHostname(config.server.host) const protocol = config.server.https ? 'https' : 'http' printServerUrls( hostname,