From b58609829262255d73363229584a2341bc4f568d Mon Sep 17 00:00:00 2001 From: Evan You Date: Thu, 7 Oct 2021 17:52:55 -0400 Subject: [PATCH] fix: avoid unnecessary pre-bundling warning --- packages/vite/src/node/optimizer/scan.ts | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/packages/vite/src/node/optimizer/scan.ts b/packages/vite/src/node/optimizer/scan.ts index 510981a4314853..ad6d19db3e7893 100644 --- a/packages/vite/src/node/optimizer/scan.ts +++ b/packages/vite/src/node/optimizer/scan.ts @@ -27,6 +27,7 @@ import { init, parse } from 'es-module-lexer' import MagicString from 'magic-string' import { transformImportGlob } from '../importGlob' import { performance } from 'perf_hooks' +import chalk from 'chalk' const debug = createDebugger('vite:deps') @@ -51,7 +52,7 @@ export async function scanImports(config: ResolvedConfig): Promise<{ let entries: string[] = [] - const explicitEntryPatterns = config.optimizeDeps?.entries + const explicitEntryPatterns = config.optimizeDeps.entries const buildInput = config.build.rollupOptions?.input if (explicitEntryPatterns) { @@ -80,9 +81,15 @@ export async function scanImports(config: ResolvedConfig): Promise<{ ) if (!entries.length) { - config.logger.warn( - 'Could not determine entry point from rollupOptions or html files. Skipping dependency pre-bundling.' - ) + if (!explicitEntryPatterns && !config.optimizeDeps.include) { + config.logger.warn( + chalk.yellow( + '(!) Could not auto-determine entry point from rollupOptions or html files ' + + 'and there are no explicit optimizeDeps.include patterns. ' + + 'Skipping dependency pre-bundling.' + ) + ) + } return { deps: {}, missing: {} } } else { debug(`Crawling dependencies using entries:\n ${entries.join('\n ')}`)