fix: add react and vue to optimizeDeps

vitejs · Jul 12, 2022 · f17d14b · f17d14b
1 parent f020066
commit f17d14b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/plugin-react/src/index.ts b/packages/plugin-react/src/index.ts
@@ -406,7 +406,10 @@ export default function viteReact(opts: Options = {}): PluginOption[] {
     config() {
       return {
         optimizeDeps: {
-          include: [reactJsxRuntimeId, reactJsxDevRuntimeId]
+          // We can't add `react-dom` because the dependency is `react-dom/client`
+          // for React 18 while it's `react-dom` for React 17. We'd need to detect
+          // what React version the user has installed. Can we do this?
+          include: [reactJsxRuntimeId, reactJsxDevRuntimeId, 'react']
         }
       }
     },

diff --git a/packages/plugin-vue/src/index.ts b/packages/plugin-vue/src/index.ts
@@ -125,6 +125,9 @@ export default function vuePlugin(rawOptions: Options = {}): Plugin {
         },
         ssr: {
           external: ['vue', '@vue/server-renderer']
+        },
+        optimizeDeps: {
+          include: ['vue']
         }
       }
     },