Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin): plugin config hook supports return promise #2800

Merged
merged 1 commit into from Apr 9, 2021
Merged

feat(plugin): plugin config hook supports return promise #2800

merged 1 commit into from Apr 9, 2021

Conversation

liuweiGL
Copy link
Contributor

@liuweiGL liuweiGL commented Mar 31, 2021 •
edited

Description

resolve #2798

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev added enhancement New feature or request p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Mar 31, 2021
@liuweiGL
Copy link
Contributor Author

liuweiGL commented Apr 7, 2021

Is the progress hanging up?

@patak-dev patak-dev merged commit 5dfd0e8 into vitejs:main Apr 9, 2021
@patak-dev
Copy link
Member

Thanks for pushing this feature forward @liuweiGL 👍🏼
We should also update the Plugin API section in the docs in another PR.

@dominikg dominikg mentioned this pull request Apr 11, 2021
Closed
@patak-dev patak-dev mentioned this pull request Jul 2, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@antfu antfu antfu approved these changes

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
enhancement New feature or request p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin's config hook supports return promise
4 participants
@liuweiGL @patak-dev @Shinigami92 @antfu