Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup old changelogs #10056

Merged
merged 1 commit into from Sep 10, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 9, 2022

Description

https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md is very long now.
This PR cleanups pre-3 version changelogs.

https://github.com/sapphi-red/vite/blob/616179ee49a1258354487cdbf758825f48d89768/packages/vite/CHANGELOG.md#previous-changelogs-2

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore 🧹 Doesn't change code behavior (priority) label Sep 9, 2022
@patak-dev
Copy link
Member

patak-dev commented Sep 9, 2022

Interesting. I think this is a good change. We are deciding to break the URL of old changelogs (not a hard break, they will reach the changelog and can then find their way). But we probably can't keep the changelog for all prev versions forever.

@patak-dev
Copy link
Member

patak-dev commented Sep 10, 2022

Ok, we need this #10062

@patak-dev patak-dev merged commit 9e65a41 into vitejs:main Sep 10, 2022
12 checks passed
@sapphi-red sapphi-red deleted the chore/cleanup-changelog branch Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore 🧹 Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants