Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cacheDir should be ignored from watch #10242

merged 4 commits into from
Dec 3, 2022


Copy link

@shigma shigma commented Sep 25, 2022


cacheDir should be ignored from watch.

Additional context

By default, cacheDir is node_modules/.vite and is ignored from watch. However user may change this path which leads to unexpected watch on this directory.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 22, 2022
Copy link

Thank you! I fixed two parts.

  1. Don't escape glob part that we added
    • We want to use this part as a glob
  2. run normalizePath to config.cacheDir
    • On windows, / will be passed to the glob and that won't work.

@patak-dev patak-dev merged commit 75dbca2 into vitejs:main Dec 3, 2022
@shigma shigma deleted the ignore-cache branch December 11, 2022 12:45
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Co-authored-by: sapphi-red <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p3-minor-bug An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants