Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types)!: remove facade type files #10903

merged 1 commit into from
Nov 13, 2022


Copy link


Removed facade type files added by #9966 for backward compatibility.
It's not long from the deprecation. But given that people shouldn't import these types from types/*, I think it's fine to remove in Vite 4.

refs #9966
refs #10243

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) breaking change labels Nov 13, 2022
@@ -111,7 +111,6 @@ export type {
} from 'types/customEvent'
// [deprecated: use vite/client/types instead]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was deprecated by #9966 and reverted by #10243 but the comment was still there.

@sapphi-red sapphi-red added this to the 4.0 milestone Nov 13, 2022
@patak-dev patak-dev enabled auto-merge (squash) November 13, 2022 07:51
@patak-dev patak-dev merged commit a309058 into vitejs:main Nov 13, 2022
@sapphi-red sapphi-red deleted the refactor/remove-facade-type-files branch November 13, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
breaking change p1-chore Doesn't change code behavior (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants